Skip to content

owners don't consume a license#3028

Merged
janiceilene merged 9 commits intomainfrom
enterprise-owners-do-not-consume-licenses
Feb 1, 2021
Merged

owners don't consume a license#3028
janiceilene merged 9 commits intomainfrom
enterprise-owners-do-not-consume-licenses

Conversation

@brntbeer
Copy link
Copy Markdown
Member

Why:

Owners don't consume a license unless they're in an organization

What's being changed:

calling it out here. unsure where else it could be mentioned but this is a great start

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 20, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@brntbeer
Copy link
Copy Markdown
Member Author

I could definitely benefit from some help here. The way i've phrased the line is not that clear i think even for me =)

@brntbeer
Copy link
Copy Markdown
Member Author

Additionally, we could do like is done in https://github.com/github/docs/blob/main/content/github/setting-up-and-managing-organizations-and-teams/adding-a-billing-manager-to-your-organization.md, and add the Note for billing managers and enterprise owners.

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for opening a PR @brntbeer 💖 I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 20, 2021
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@brntbeer
Copy link
Copy Markdown
Member Author

bump. @janiceilene any luck getting review?

@brntbeer brntbeer removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

I'll check with the team @brntbeer 💛 Thanks for the bump!

Copy link
Copy Markdown
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brntbeer thanks for the gentle bump on this! I had a few suggestions that I think are valid but let me know 😄

Comment thread content/github/setting-up-and-managing-your-enterprise/roles-in-an-enterprise.md Outdated
Copy link
Copy Markdown
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ⚡ merging now

@megbird megbird added the ready to merge This pull request is ready to merge label Feb 1, 2021
@janiceilene janiceilene merged commit 637facf into main Feb 1, 2021
@janiceilene janiceilene deleted the enterprise-owners-do-not-consume-licenses branch February 1, 2021 20:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants